Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: fix test workflow and some minor changes #24

Merged
merged 3 commits into from
Jan 19, 2023

Conversation

vinhphuctadang
Copy link
Contributor

Changes

  • Update test, runner (because ubuntu 22.04 is not supported by mongodb yet)

* chore: add debug

* chore: print error saving file

* chore: add path 2 log

* chore: add rename err

* fix: only rename once

* chore: return error when readFile() and copyFile() returns error
* chore: test action

* chore: add url string

* chore: read header

* chore: more log

* chore: don't use ubuntu latest as mongodb haven't support it
@vinhphuctadang vinhphuctadang marked this pull request as ready for review January 5, 2023 13:44
@saniales saniales merged commit c4c97da into tryvium-travels:main Jan 19, 2023
@vinhphuctadang vinhphuctadang deleted the f/fix-test-workflow branch January 29, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants