Add support for MPLS-TP #104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
italobusi
commented
Jun 26, 2020
italobusi
commented
Jun 26, 2020
italobusi
commented
Jun 26, 2020
italobusi
commented
Jun 26, 2020
italobusi
commented
Jun 26, 2020
italobusi
commented
Jun 26, 2020
italobusi
commented
Jun 26, 2020
italobusi
commented
Jul 3, 2020
italobusi
commented
Jul 3, 2020
italobusi
force-pushed
the
mpls-tp-support
branch
from
12dee6d
to
bd2e35e
Compare
tsaad-dev
reviewed
Jul 10, 2020
ietf-mpls-te-types.yang
Outdated
| while packets for different LSPs can be forwarded on | ||
| different component links. | ||
| "The load-balancing algorithm ensures that packets, which | ||
| are forwarding based on the same label at the top of the |
There was a problem hiding this comment.
How about:
The load-balancing algorithm ensures incoming MPLS packets with the same top MPLS label and that egress on a on a LAG or bundled TE link get forwarded on the same component link of the LAG.
tsaad-dev
reviewed
Jul 10, 2020
| the same flow are forwarded on the same component link, | ||
| while packets for different flows can be forwarded on | ||
| different component links. | ||
| the same flow are forwarded on the same component link. | ||
|
|
||
| Packets for different flows within the same LSP can be | ||
| forwarded on different component links."; |
There was a problem hiding this comment.
How about:
The load-balancing algorithm ensures that packets characterized as the same flow (e.g. based on IP 5-tuple) that egress on a LAG or a bundled TE link are forwarded on the same component link.
tsaad-dev
reviewed
Jul 10, 2020
ietf-mpls-te-types.yang
Outdated
| grouping te-packet-link-bandwidth { | ||
| description | ||
| "Bandwidth for MPLS-TP. "; | ||
| leaf mpls-tp-bandwidth { |
There was a problem hiding this comment.
pls use the typedef bandwidth-kbps
Aligned with the master branch
Proposal updated based on the discussion in the 2020-06-16 TEAS call: tsaad-dev#60
Updated as discussed during the TEAS call on 2020-06-26
Updated as discussed during the TEAS call on 2020-06-26
Updated as discussed during the TEAS call on 2020-06-26
Fixing an issue with MPLS-TE label definition
Fixing few issues: - MPLS-TE label augmentations - compilation errors
Fixing compilation errors
Fixing compilation errors
Fixing compilation errors
Removing references to MPLS-TP
Output of pyang compilation
Models updated based on feedbacks received during the 2020-07-03 TEAS Call
YANG model aligned with the latest version of te-topology-packet
Updated mpls-te-types to address Tarek's review comments as discussed during the call on 2020-07-10
italobusi
force-pushed
the
mpls-tp-support
branch
from
c5756e7
to
5ca616b
Compare
Updated after compilation
This was referenced Jan 18, 2021
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes to add support for MPLS-TP using common MPLS-TE topology and tunnel models