-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uniform attribute level refactoring types #98
Uniform attribute level refactoring types #98
Conversation
This change has many implications that you did not consider. |
…are updated to be consistent with the previous implementation
@jodavimehran Thanks for updating |
…re updated to be consistent with the previous implementation
There are some attribute level refactoring-types like ChangeAttributeTypeRefactoring, RenameAttributeRefactoring, MergeAttributeRefactoring, and SplitAttributeRefactoring has instances of VariableDeclaration class as attributes to keep the state of a refactored attribute before and after refactoring.
However, the other attribute level refactoring types like MoveAttributeRefactoring and AddAttributeAnnotationRefactoring have instances of UMLAttribute class to do the same.
Therefore, to make the code more uniform, it is better to refactor those refactoring classes to use UMLAttribute, which contains more information in comparison to VariableDeclaration.