This repository has been archived by the owner on Jul 3, 2019. It is now read-only.
Constructor injection fix #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A class with several dependencies injected through its constructor fails to receive the first dependency if the second one is constructor-injected and has at least one dependency.
The global Array _parameterValues was incorrectly shared between reentrant calls to MethodInjectionPoint.applyInjection, thus losing some dependencies for injection.
|
I have bumped into this myself. |
tschneidereit
added a commit
that referenced
this pull request
Feb 15, 2013
Constructor injection fix
|
Urgh, what an embarrassing bug! Thanks a lot for fixing it. :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found an issue in constructor injection where some dependencies would surprisingly be injected as null when recursively applying ConstructorInjectionPoint injection.
This was caused by the use of a
private static const _parameterValues: Arrayin MethodInjectionPoint.as.A first commit has a new test to help ascertain that this is a reasonable use case. The test fails at that revision.
The second commit changes MethodInjectionPoint.as to make the test pass.