Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dark mode and dynamic font support #14

Merged
merged 3 commits into from
Mar 7, 2021
Merged

Conversation

tschob
Copy link
Owner

@tschob tschob commented Mar 7, 2021

Before

After

@codecov-io
Copy link

codecov-io commented Mar 7, 2021

Codecov Report

Merging #14 (604f0b1) into main (3e479ac) will decrease coverage by 0.07%.
The diff coverage is 74.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
- Coverage   77.96%   77.89%   -0.08%     
==========================================
  Files          62       62              
  Lines        1729     1782      +53     
==========================================
+ Hits         1348     1388      +40     
- Misses        381      394      +13     
Flag Coverage Δ
QAMenu 77.89% <74.13%> (-0.08%) ⬇️
QAMenuUIKit 62.84% <74.13%> (+0.70%) ⬆️
QAMenuUtils 97.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lper/UnsupportedItemView/UnsupportedItemView.swift 0.00% <0.00%> (ø)
.../ItemViews/ProgressItemView/ProgressItemView.swift 20.00% <50.00%> (+8.67%) ⬆️
...l/UI/ItemViews/ButtonItemView/ButtonItemView.swift 87.93% <86.66%> (-0.45%) ⬇️
...UI/ItemViews/BooleanItemView/BooleanItemView.swift 92.68% <87.50%> (-1.26%) ⬇️
...ickableStringItemView/PickableStringItemView.swift 36.73% <87.50%> (+8.16%) ⬆️
...l/UI/ItemViews/StringItemView/StringItemView.swift 91.73% <88.88%> (-0.30%) ⬇️
...ernal/UI/ItemViews/Base/FooterViewSupporting.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e479ac...604f0b1. Read the comment docs.

@tschob tschob merged commit a41cf74 into main Mar 7, 2021
@tschob tschob deleted the feature/dark-mode branch March 7, 2021 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants