Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in applying plugin from a shared script #8

Closed
rzabini opened this issue Oct 9, 2015 · 2 comments
Closed

Error in applying plugin from a shared script #8

rzabini opened this issue Oct 9, 2015 · 2 comments

Comments

@rzabini
Copy link
Contributor

rzabini commented Oct 9, 2015

Hi,
I was trying to apply the plugin from a shared script, which also contains the buildscript classpath.
In this script I also apply the versionStrategy RebuildVersionStrategy.INSTANCE to the release task configuration.

I found here that in this case:

... you have to use the plugin's fully qualified class name, rather than its ID

So I used this:

project.apply plugin: de.gliderpilot.gradle.semanticrelease.SemanticReleasePlugin

But the got an error on the application of org.ajoberstar.grgit.* (two) plugins, because they are applied by name in the apply method of class SemanticReleasePlugin.

I was able to make it work by using the fully qualified class name and rebuilding the semantic-release plugin:

plugins.apply org.ajoberstar.gradle.git.release.base.BaseReleasePlugin
plugins.apply org.ajoberstar.gradle.git.base.GrgitPlugin

What do you think?
Thank you.

@tschulte tschulte added this to the 1.1 milestone Oct 9, 2015
@tschulte
Copy link
Owner

tschulte commented Oct 9, 2015

Yes, that would be OK. @rzabini Do you want to create a Pull-Request?

tschulte added a commit that referenced this issue Oct 11, 2015
Pull request for  #8: Error in applying plugin from a shared script
@tschulte
Copy link
Owner

closed with d0ae51c

@tschulte tschulte reopened this Oct 13, 2015
tschulte added a commit that referenced this issue Oct 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants