forked from vert-x3/vertx-micrometer-metrics
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Gauge lookup infinite loop when CompositeRegistry is still empty
Follows-up on vert-x3#143 Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
- Loading branch information
1 parent
afccbf9
commit 49e3e1c
Showing
2 changed files
with
61 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 changes: 45 additions & 0 deletions
45
src/test/java/io/vertx/micrometer/EmptyCompositeMeterRegistryTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
/* | ||
* Copyright 2022 Red Hat, Inc. and/or its affiliates | ||
* and other contributors as indicated by the @author tags. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package io.vertx.micrometer; | ||
|
||
import io.micrometer.core.instrument.composite.CompositeMeterRegistry; | ||
import io.vertx.ext.unit.TestContext; | ||
import io.vertx.ext.unit.junit.VertxUnitRunner; | ||
import org.junit.Test; | ||
import org.junit.runner.RunWith; | ||
|
||
@RunWith(VertxUnitRunner.class) | ||
public class EmptyCompositeMeterRegistryTest extends MicrometerMetricsTestBase { | ||
|
||
@Override | ||
protected MicrometerMetricsOptions metricOptions() { | ||
CompositeMeterRegistry emptyCompositeRegistry = new CompositeMeterRegistry(); | ||
return new MicrometerMetricsOptions() | ||
.setRegistryName(registryName) | ||
.setMicrometerRegistry(emptyCompositeRegistry) | ||
.setEnabled(true); | ||
} | ||
|
||
@Test | ||
public void simplyStarts(TestContext ctx) { | ||
vertx = vertx(ctx); | ||
|
||
// If the task is executed then the gauge lookup succedeed | ||
vertx.executeBlocking(prom -> prom.complete(), ctx.asyncAssertSuccess()); | ||
} | ||
} |