Do not serialize access to gauge objects #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jotak would mind reviewing this? Thank you |
Fixes vert-x3#91 Micrometer does not let us access the object that is referenced in a gauge. For this reason, we have to put such objects in a map which keys are the gauge id. (Note: we have to do this because our gauges are computed dynamically with the provided tags.) So far, to avoid race conditions, the access to gauges has been serialized. But that comes with an important performance impact. The solution proposed here consists in using: - a non-blocking construct instead of synchronization - having a single gaugesTable for all Gauges object instance (multiple Gauges instances can try to create the same gauge concurrently) Also, sometimes multiples Vert.x instances can be created in the same JVM. A good practice is to provide a name to the registry using MetricsOptions, but if the user does not, the same registry (can be used to store data). That is why we need to store the gaugesTable in static map in VertxMetricsFactoryImpl. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
added a commit
to tsegismont/vertx-micrometer-metrics
that referenced
this pull request
Jun 10, 2022
Backport of vert-x3#143 Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
added a commit
to tsegismont/vertx-micrometer-metrics
that referenced
this pull request
Jun 10, 2022
Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
added a commit
to tsegismont/vertx-micrometer-metrics
that referenced
this pull request
Jun 10, 2022
Backport of vert-x3#143 to 4.2 branch Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
added a commit
to tsegismont/vertx-micrometer-metrics
that referenced
this pull request
Jun 17, 2022
Backport of vert-x3#143 to 4.2 branch Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
added a commit
that referenced
this pull request
Jun 17, 2022
Backport of #143 to 4.2 branch Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
added a commit
that referenced
this pull request
Jun 17, 2022
Backport of #143 Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
added a commit
to tsegismont/vertx-micrometer-metrics
that referenced
this pull request
Jul 5, 2022
Follows-up on vert-x3#143 Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
added a commit
to tsegismont/vertx-micrometer-metrics
that referenced
this pull request
Jul 5, 2022
Follows-up on vert-x3#143 Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
added a commit
that referenced
this pull request
Jul 5, 2022
Follows-up on #143 Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
added a commit
that referenced
this pull request
Jul 5, 2022
Follows-up on #143 Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #91
Micrometer does not let us access the object that is referenced in a gauge. For this reason, we have to put such objects in a map which keys are the gauge id.
(Note: we have to do this because our gauges are computed dynamically with the provided tags.)
So far, to avoid race conditions, the access to gauges has been serialized. But that comes with an important performance impact.
The solution proposed here consists in using:
Also, sometimes multiples Vert.x instances can be created in the same JVM. A good practice is to provide a name to the registry using MetricsOptions, but if the user does not, the same registry (can be used to store data).
That is why we need to store the gaugesTable in static map in VertxMetricsFactoryImpl.