remove ./node_modules/.bin from npm scripts

[collinsauve]

Fixes issue #74, which broke linting and tests on Windows.

[paulius005]

does this work if eslint is not installed globally?

[paulius005]

to get this to work I normally have to modify my path to include :node_modules/.bin/

[paulius005]

I'm more in favor of the style of #75

[collinsauve]

I don't have eslint in my path, and I don't think I have it installed in npm global (npm ls -g | grep eslint is empty).

npm lint runs for me on windows (as do the other scripts).

[vhmth]

I like the dot-delimiter because it makes this repo self-contained. Right now this config makes the assumption that the user has exported node_modules from every subdir on their path. Does this not work with ./ as separate commands on Windows?

[paulius005]

@vhmth looks like it does. Take a look @ #75

[vhmth]

My vote would be for ./ as separate commands for the Windows case.

[collinsauve]

Here's a comment about this problem by isaacs (inventor of npm):

Also, never ever write ./node_modules/.bin/ in your scripts. Seriously, that should just throw. What if the dep is somewhere else, installed globally, or as a parent's dep? npm puts ./node_modules/.bin in the PATH environ for a reason. Do not tightly couple to non-portable platform-specific paths!

Note that he says "npm puts ./node_modules/.bin in the PATH". I did not need to install anything globally to get this to work.

[collinsauve]

Does this not work with ./ as separate commands on Windows?

It works, but (as well as taking isaacs comment) I found it kind of hacky in that it creates scripts that really would only be used as building blocks for other scripts, and never run independently.

[vhmth]

https://www.useloom.com/share/e39a52d3b722475294409f092ef21e44

[collinsauve]

:) Thanks for the insight. I don't know this kind of history / insight into npm - I wasn't aware it was this complex and debated.

I actually generally work in C# (just using JS for a chrome extension), so when you talk about "too much dynamic linking" going on in node - I definitely hear that!

So you've convinced me - since you value predictability and isolation over my arbitrary "cleanliness" of the scripts, #75 would be the way to go.

[vhmth]

@collinsauve cool glad I could convince you! There is no right or wrong answer here though. Totally game to leave it up to @tshaddix since he has to sign off on stuff like this too. :-)

[tshaddix]

@vhmth I'm happy to go with whatever you see as the best option here :)

[tshaddix]

Closing this in favor of #83