Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Justify default values for lo and hi #2078

Closed
jeromekelleher opened this issue Jun 27, 2022 · 4 comments
Closed

Justify default values for lo and hi #2078

jeromekelleher opened this issue Jun 27, 2022 · 4 comments
Assignees
Milestone

Comments

@jeromekelleher
Copy link
Member

Not obvious where these came from. In particular, why 2 and not 1 (or zero) for lo?

I've put a placeholder into the MicrosatMutationModel class.

@andrewkern
Copy link
Member

these defaults weren't chosen for any good reason. lo=2 makes sense as a default rather than 1 because these are repeats-- so repeat number > 1 by definition (usually)

@jeromekelleher
Copy link
Member Author

Sound reasonable to me - we just need to document these choices. People will assume that the defaults are the Right Choice.

@andrewkern
Copy link
Member

going to close this out now that #2080

@jeromekelleher
Copy link
Member Author

See #2086 for discussion on changing lo to 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants