Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep all nodes in simulation from pedigree #2129

Closed
jeromekelleher opened this issue Dec 1, 2022 · 4 comments
Closed

Keep all nodes in simulation from pedigree #2129

jeromekelleher opened this issue Dec 1, 2022 · 4 comments
Milestone

Comments

@jeromekelleher
Copy link
Member

We would like to be able to track the passage of all ancestral material through the pedigree ancestors, not just those in which coalescence happens to occur (as well as the bits of segments that don't happen to coalesce when there is a coalescence).

Once we have a figured out how to keep unary nodes across the various models (#2128) I think this will be relatively straightforward, because we've already allocated nodes for every individual in the pedigree and we can reuse the machinery for that/the record_full_arg option.

cc @sgravel

@petrelharp
Copy link
Contributor

So - keep the bits of ancestry for which they are ancestral to actual samples, right? For reference, the analogous thing in SLiM is called "retaining" (instead of "remembering", which implies actually making them samples): https://tskit.dev/pyslim/docs/latest/tutorial.html#retaining-individuals

@jeromekelleher
Copy link
Member Author

Yep, that's it.

@jeromekelleher jeromekelleher added this to the 1.3.0 milestone Dec 5, 2022
@jeromekelleher
Copy link
Member Author

Probably better to implement #2133 first before this, as the pedigree simulation calls into some of the DTWF infrastructure.

@GertjanBisschop
Copy link
Member

Can be closed. Implemented in #2176.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants