Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMC with record_full_arg produces discontinuous nodes #2146

Closed
hyanwong opened this issue Dec 10, 2022 · 4 comments
Closed

SMC with record_full_arg produces discontinuous nodes #2146

hyanwong opened this issue Dec 10, 2022 · 4 comments

Comments

@hyanwong
Copy link
Member

I'm not what "SMC" means for a full ARG, so I'm not sure if this is expected, but I thought it worth noting:

ts = msprime.sim_ancestry(
    4,
    sequence_length=1e4,
    recombination_rate=1e-5,
    record_full_arg=True,
    random_seed=14,
    model="SMC",
)
ts.draw_svg(style=".n19 > .sym {fill:red}")

image

@jeromekelleher
Copy link
Member

jeromekelleher commented Dec 11, 2022

Ah, that's because 19 is above the local root in the middle tree. Another reason for making snipping out fully-coalesced bits optional @GertjanBisschop?

I don't think this is particularly unexpected though.

@hyanwong
Copy link
Member Author

Ah, that's because 19 is above the local root in the middle tree.

Yes indeed. I wonder if this is a reason to continue the full_arg even after local coalescence (until all the trees have met their own local coalescent.

Another reason for making snipping out fully-coalesced bits optional @GertjanBisschop?

I don't think this is particularly unexpected though.

No, I guess not, but it's an edge case in the SMC model that people might not have thought about.

@jeromekelleher
Copy link
Member

I don't think this is an actionable issue, so closing.

@hyanwong
Copy link
Member Author

Possibly worth moving to a discussion. Or maybe it's easily searchable enough here. There's som complexity in what SMC actually means, which might be worth a forum for others to add to / search for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants