Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MAX_ALLELES=255 restriction #466

Closed
jeromekelleher opened this issue Apr 28, 2018 · 1 comment
Closed

Remove MAX_ALLELES=255 restriction #466

jeromekelleher opened this issue Apr 28, 2018 · 1 comment
Milestone

Comments

@jeromekelleher
Copy link
Member

jeromekelleher commented Apr 28, 2018

This is currently an artificial restriction which causes issues in certain extreme cases.

Note that we don't need to efficiently handle very large numbers of alleles; the current algorithm which is efficient for small numbers of alleles is perfectly fine.

cc @bhaller

@jeromekelleher jeromekelleher added this to the Release 0.5.1 milestone Apr 28, 2018
@bhaller
Copy link

bhaller commented Apr 28, 2018

Yes, this sounds right. Fixing this is not at all a priority, but it is conceivable that a user trying to do something weird in SLiM might run into it. Mostly, fixing it will just make a couple of tests in my test suite go from red to green. :->

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants