Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dependence on 0/1 mutations in ancestors ts explicit or remove #107

Closed
jeromekelleher opened this issue Sep 7, 2018 · 4 comments
Closed

Comments

@jeromekelleher
Copy link
Member

Currently we have to have 0/1 mutation in the ancestors ts, or assertions will fail. Either

  1. Make this requirement explicit and test for it or
  2. Update the input code to ignore the actual states of the values.

Probably (1) is less nasty, as we're unlikely to forget about this if we're forced to set the values to 0/1 all the time.

@jeromekelleher
Copy link
Member Author

Also need to update make_ancestors_ts to allow us set these values to 0/1 appropriately.

@hyanwong
Copy link
Member

I think #437 is probably relevant here: we should revisit this issue as part of allowing >2 alleles in matching.

@jeromekelleher
Copy link
Member Author

I'm not sure this is true any more - we're matching with arbitrary alleles in the extend operation happily (if probably slightly wrongly #437)

@jeromekelleher
Copy link
Member Author

I'm going to close - we can reopen if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants