return suitable string when error occur #34 #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* get rx, tx timestamp * no more call SystemTime::now() on oneway mode * fix cargo fmt * print only rx timestamp * fix fmt
* Implement HW TX timestamp Even if failed to set HW TX timestamp, SW TX timestamp is still can be used. * Cargo fmt, Clippy * Remove perror * Remove print, fix typo
* change protocol * fix fmt, clippy * change server get rx by packet, clean code * server identifies act as opcode * store ts only last one and server don't get oneway parameter * get SW timestamp immediately after receive the message * clean code * change opcode match in server * error handling about negative elapsed time * fix fmt, clippy * server prints negative elapsed time * simplify get tx_timestamp at packet * fix fmt
tribela
reviewed
Aug 30, 2023
| if !tc_map.contains_key(&prio.as_i64().unwrap()) { | ||
| tc_map.insert(prio.as_i64().unwrap(), tc_map.len() as i64); | ||
| for (prio, priomap) in config.as_mapping().expect("failed to parse cbs schedule") { | ||
| if !tc_map.contains_key(&prio.as_i64().expect("failed to parse cbs schedule")) { |
There was a problem hiding this comment.
"Failed to parse 'prio' as integer" is more precise error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change unwrap to expect
libtsn/src/cbs.rs
Line 35 in 64745a9
libtsn/src/cbs.rs
Line 36 in 1042118
and change necessary last_os_error to error msg
libtsn/src/lib.rs
Line 84 in 64745a9
libtsn/src/lib.rs
Line 84 in 1042118