change latency protocol #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tribela
requested changes
May 23, 2023
There was a problem hiding this comment.
On src/bin/latency.rs#L167, Save SW rx timestamp right after recv. For "one way mode packet but HW doesn't support HW RX timestamp"
Again, These are required.
- SW timestamp right after TX/RX ALWAYS. Because some HW doesn't support HW timestamp. HW timestamp function can overwrite timestamp after SW timestamp if supported.
tribela
reviewed
May 26, 2023
tribela
requested changes
May 26, 2023
tribela
requested changes
May 26, 2023
tribela
requested changes
May 30, 2023
tribela
requested changes
May 30, 2023
tribela
requested changes
May 30, 2023
tribela
approved these changes
May 30, 2023
junppyo
added a commit
that referenced
this pull request
May 30, 2023
* change protocol * fix fmt, clippy * change server get rx by packet, clean code * server identifies act as opcode * store ts only last one and server don't get oneway parameter * get SW timestamp immediately after receive the message * clean code * change opcode match in server * error handling about negative elapsed time * fix fmt, clippy * server prints negative elapsed time * simplify get tx_timestamp at packet * fix fmt
tribela
added a commit
that referenced
this pull request
Aug 30, 2023
* get rx, tx timestamp * no more call SystemTime::now() on oneway mode * fix cargo fmt * Fix sock_open to return created vlan name instead of interface name (#32) * Get rx timestamp from HW on latency app (#33) * get rx, tx timestamp * no more call SystemTime::now() on oneway mode * fix cargo fmt * print only rx timestamp * fix fmt * Revert "Fix sock_open to return created vlan name instead of interface name (#32)" (#35) This reverts commit 2cec046. * Implement HW/SW TX timestamp feature (#37) * Implement HW TX timestamp Even if failed to set HW TX timestamp, SW TX timestamp is still can be used. * Cargo fmt, Clippy * Remove perror * Remove print, fix typo * change latency protocol (#36) * change protocol * fix fmt, clippy * change server get rx by packet, clean code * server identifies act as opcode * store ts only last one and server don't get oneway parameter * get SW timestamp immediately after receive the message * clean code * change opcode match in server * error handling about negative elapsed time * fix fmt, clippy * server prints negative elapsed time * simplify get tx_timestamp at packet * fix fmt * get HW tx_timestamp that apply to latency * get rx, tx timestamp * no more call SystemTime::now() on oneway mode * merge hw_tx_timestamp * Consume tx timestamp after sending SYNC packet * Warn if SW TX timestamp is used --------- Co-authored-by: Jeong Arm <kjwonmail@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client send tx timestamp at oneway mode.
Client get rx timestamp at normal mode.