Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reports Configuration Step 7 style error #77

Closed
joebordes opened this issue Jun 2, 2016 · 2 comments
Closed

Reports Configuration Step 7 style error #77

joebordes opened this issue Jun 2, 2016 · 2 comments
Assignees
@kikojover

Comments

@joebordes
Copy link
Contributor

Using Chrome.
In step 7 of creating/editing a report the standard conditions are hidden but the height of the hidden rows is respected as a big blank space. The div inside the rows are hidden but the rows aren't so, for some reason the height the div will have is reserved.

errorcfginformechrome01

errorcfginformechrome02

In Firefox this looks correct:

errorcfginformefirefox

The code is in:

Smarty/templates/ReportFilters.tpl
@joebordes joebordes assigned joebordes and kikojover and unassigned joebordes Jun 2, 2016
kikojover added a commit that referenced this issue Jun 4, 2016
@kikojover
Fix(Report configuration) Solve issue #77. Fix hidden row height visi…
39c365a 
…ble on Chrome.
@kikojover
Copy link
Contributor

For some (unknown) reason Chrome sets height of rows, either hidden or visible. I've setted in each tr a height of 1px.

Tested on Chrome and Firefox.

@joebordes
Copy link
Contributor Author

Looks great!
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kikojover kikojover

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joebordes @kikojover