css_put imbalance

Signed-off-by: Tadeusz Struk <tadeusz.struk@linaro.org> Change-Id: I453cfab851487f9fe0d47b5cbd3be657c7344689
tstruk · Jun 1, 2022 · 4bea09c · 4bea09c
1 parent 3bfd8e2
commit 4bea09c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/include/linux/cgroup-defs.h b/include/linux/cgroup-defs.h
@@ -53,6 +53,7 @@ enum {
 	CSS_RELEASED	= (1 << 2), /* refcnt reached zero, released */
 	CSS_VISIBLE	= (1 << 3), /* css is visible to userland */
 	CSS_DYING	= (1 << 4), /* css is dying */
+	CSS_RELEASING	= (1 << 5), /* css is being released */
 };
 
 /* bits in struct cgroup flags field */

diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
@@ -1565,7 +1565,7 @@ void cgroup_kn_unlock(struct kernfs_node *kn)
 
 printk("!!!!! cgroup_kn_unlock css %llx flags %x !!!\n", &cgrp->self, cgrp->self.refcnt);
 	//if (!percpu_ref_is_dying(&cgrp->self.refcnt))
-	if (!(cgrp->self.refcnt & CSS_RELEASED))
+	if (!(cgrp->self.flags & CSS_RELEASING))
 		cgroup_put(cgrp);
 }
 
@@ -5112,6 +5112,7 @@ static void css_release(struct percpu_ref *ref)
 	struct cgroup_subsys_state *css =
 		container_of(ref, struct cgroup_subsys_state, refcnt);
 printk("!!!!! css_release css %llx !!!\n", css);
+	css->flags |= CSS_RELEASING;
 	INIT_WORK(&css->destroy_work, css_release_work_fn);
 	queue_work(cgroup_destroy_wq, &css->destroy_work);
 }