Added support to redefine users of a repository #166
Conversation
| @@ -64,6 +64,7 @@ func SetupRouter() *pat.Router { | |||
| router.Post("/user", http.HandlerFunc(newUser)) | |||
| router.Delete("/user/{name}", http.HandlerFunc(removeUser)) | |||
| router.Delete("/repository/revoke", http.HandlerFunc(revokeAccess)) | |||
| router.Put("/repository/set", http.HandlerFunc(setAccess)) | |||
There was a problem hiding this comment.
What about grant instead of set?
There was a problem hiding this comment.
A route called repository/grant already exists and its purpose is different of set.
grant method just append new users to the list of users, ignoring the already existing users
revoke does the reverse, but also ignores the others too.
The set method, forces the users list to be the same as the users argument. Reseting all the user array. This method is important to garantee a correct updating permission flux in-one-action that normally will be implemented with revoke and grant methods, and can be dangerous if one of them does not works for some reason.
There was a problem hiding this comment.
I see, that makes sense. Thanks for clarifying!
There was a problem hiding this comment.
I think that instead "set" we should just create a route to change/update the repository attributes. A put in repository.
There was a problem hiding this comment.
Makes sense. I agree. There's already a PUT in repository/:name that serves such a purpose – renaming a repository. Perhaps we should extend it and support changing Users, ReadOnlyUsers and IsPublic attributes too.
Added support to redefine users of a repository
Thanks, @scorphus :)