Added support to update repository data

[ricardodani]

Its important to notice that Update does not renames the repository, cause the Rename method removes the old repository in mongo, inserts the new and renames the filesystem repository. While Update just do a simple database update. So its important to maintain this two methods separeted to avoid an intermitent state on database in cases that one of them doesn`t works.

[andrewsmedina]

@ricardodani I think that you can remove the rename handler and merge it into the update handler. So you can use the /repository/:name path instead /reository/:name/update.

[ricardodani]

@andrewsmedina I preferred to do it this way because the repository.Rename doesn't updates the repository, in fact, this method removes and add`s a new one in the database and moves the git repository in filesystem.

Thinking thus, Rename method acts very different from the Update which is what really makes an Update operation in the database. My concern is not with the dogma of a method to do just one operation. My concern is with the consistency between the operations it processes and the order of things.

For example:

• We attempt a rename operation: it is executed successfully, then the update is done and fails, what to do? Returns the repository in a flashing or tries to "rollback" the rename?
• Other alternative: We first started doing the update. It runs successfully, the rename fails. Do we do the "rollback" of the update? Or also return the repository "half edited"?

Thinking of giving the things simple, I separated the method in these two.

What do you think about this? Would you still recommend using only one route?

Thanks

[andrewsmedina]

@ricardodani first of all the PUT in /repository/:name call the rename handler because when it was implemented the only attribute that the repository had was the name. And currently the repository.Rename is broken, this method will erase all other attributes on rename.

My idea is merge update and rename, and only do the "filesystem" stuff when the name will be changed.

A way to fix the "rollback" is to make all handler actions as atomic actions for this handler. tsuru has a package to do it. And it is a current problem in the rename handler.

I think that this way will make the api more consistent.

[fsouza]

If we want to rename a repository, we should stop using the name as the id of the document. That remove + insert is ugly.

[scorphus]

It lacks a partial update test, but I believe it works. Apart from the ugliness of the insert+remove, it LGTM.

[scorphus]

I think err should be returned instead, no?

[ricardodani]

If you notice the erros when they happen, they are aways returned imediatly, in this case i have shure that no errors ocurred, so, return no error

[ricardodani]

I understand what you said now. Fixed. But in a different way, returning error explicity on the condition, not on the bottom of the method (which is explict that no errors ocurred)

[scorphus]

It won't build with no return at the end, mate 😉

[andrewsmedina]

@ricardodani thank you!