auth: specialize the "team not found" error

tsuru · Aug 1, 2014 · 9c2ea45 · 9c2ea45
1 parent 61f36b0
commit 9c2ea45
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/auth/team.go b/auth/team.go
@@ -17,8 +17,9 @@ import (
 )
 
 var (
-	ErrInvalidTeamName   = errors.New("Invalid team name")
-	ErrTeamAlreadyExists = errors.New("Team already exists")
+	ErrInvalidTeamName   = errors.New("invalid team name")
+	ErrTeamAlreadyExists = errors.New("team already exists")
+	ErrTeamNotFound      = errors.New("team not found")
 
 	teamNameRegexp = regexp.MustCompile(`^[a-zA-Z][-@_.+\w\s]+$`)
 )
@@ -118,6 +119,9 @@ func GetTeam(name string) (*Team, error) {
 	}
 	err = conn.Teams().FindId(name).One(&t)
 	if err != nil {
+		if err == mgo.ErrNotFound {
+			err = ErrTeamNotFound
+		}
 		return nil, err
 	}
 	return &t, nil

diff --git a/auth/team_test.go b/auth/team_test.go
@@ -199,6 +199,6 @@ func (s *S) TestGetTeam(c *gocheck.C) {
 	c.Assert(t.Name, gocheck.Equals, team.Name)
 	c.Assert(t.Users, gocheck.HasLen, 0)
 	t, err = GetTeam("wat")
-	c.Assert(err, gocheck.NotNil)
+	c.Assert(err, gocheck.Equals, ErrTeamNotFound)
 	c.Assert(t, gocheck.IsNil)
 }