fix lint

tsuru · Mar 20, 2024 · a900772 · a900772
1 parent 1cd0e4e
commit a900772
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/job/job.go b/job/job.go
@@ -298,9 +298,9 @@ func (*jobService) UpdateJob(ctx context.Context, newJob, oldJob *jobTypes.Job,
 	}
 	newJobActiveDeadlineSeconds := buildActiveDeadline(newJob.Spec.ActiveDeadlineSeconds)
 
-	deployOptionsHasChanged, err := updateDeployOptions(oldJob, newJob)
-	if err != nil {
-		return err
+	deployOptionsHasChanged, updateErr := updateDeployOptions(oldJob, newJob)
+	if updateErr != nil {
+		return updateErr
 	}
 
 	// NOTE: we're merging newJob as dst in mergo, newJob is not 100% populated, it just contains the changes the user wants to make
@@ -312,7 +312,7 @@ func (*jobService) UpdateJob(ctx context.Context, newJob, oldJob *jobTypes.Job,
 	}
 
 	if deployOptionsHasChanged {
-		err = buildWithDeployAgent(ctx, newJob)
+		err := buildWithDeployAgent(ctx, newJob)
 		if err != nil {
 			return err
 		}