Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image deploy entrypoint and cmd parsing #1484

Closed
cezarsa opened this issue Oct 28, 2016 · 0 comments
Closed

Image deploy entrypoint and cmd parsing #1484

cezarsa opened this issue Oct 28, 2016 · 0 comments
Milestone

Comments

@cezarsa
Copy link
Member

cezarsa commented Oct 28, 2016

The way tsuru handles reading the entrypoint from a image if a Procfile is not present is wrong. There are two major problems:

  1. Only ENTRYPOINT is being read, where the correct approach would be to read both ENTRYPOINT and CMD directives and use them accordingly in the started containers.
  2. Once we read the entrypoint we serialize it in a single string instead of using the original []string, this can cause a myriad of escaping problems and doesn't serve any real purpose. It would be much better to preserve the original []string.
@cezarsa cezarsa closed this as completed in 730d366 Nov 1, 2016
@andrestc andrestc added this to the 1.2 milestone Nov 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants