provision/kubernetes: support deploy cancelation #2030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrestc
changed the title
andrestc
force-pushed
the
kube-deploy-cancel
branch
from
207b2c0
to
3b304f1
Compare
andrestc
changed the title
cezarsa
requested changes
May 2, 2018
provision/kubernetes/helpers.go
Outdated
| err = errors.Errorf("timeout after %v", timeout) | ||
| case <-ctx.Done(): | ||
| if onCancel == nil { | ||
| err = errors.Errorf("canceled after %v", time.Since(start)) |
There was a problem hiding this comment.
I think we should call err = errors.Wrapf(ctx.Err(), ... here. This way we would be able to differentiate between DeadlineExceeded and explicit cancelation of events.
cezarsa
approved these changes
May 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements cancelation for kubernetes deploys.