Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App name could conflict with platform name if both use same name #712

Closed
morpheu opened this issue Feb 14, 2014 · 2 comments
Closed

App name could conflict with platform name if both use same name #712

morpheu opened this issue Feb 14, 2014 · 2 comments
Assignees
@fsouza
Labels
bug
Milestone
0.10.0

Comments

@morpheu
Copy link
Member

morpheu commented Feb 14, 2014

Tsuru should handle app name with same name as platform name - maybe using app id as image name and app name as tag (e.g. 52d40a6892021c4001e3f86e4:ruby20)
@andrewsmedina andrewsmedina mentioned this issue Apr 29, 2014
Closed
@cezarsa
Copy link
Member

cezarsa commented Apr 30, 2014

This issue has been partially solved by @renanoliveira in 35a6f17. Now tsuru won't allow using the same app name as a platform name.
Do you guys think we should still change how the app image name is generated?

@andrewsmedina andrewsmedina reopened this Apr 30, 2014
@guestisp
Copy link
Contributor

I don't like the idea to force a different name between app and platform.
More deeply, which is the exact issue? Why tsuru is unable to detect if "php" is an app or a platform ?

@cezarsa cezarsa added this to the 0.10.0 milestone Dec 3, 2014
@fsouza fsouza self-assigned this Dec 8, 2014
fsouza pushed a commit that referenced this issue Dec 8, 2014
provision/docker: prepend "app-" to the app image name
cd6571a 
Still to come: a migration script and the removal of the restriction in
the app package.

Related to #712.
fsouza pushed a commit that referenced this issue Dec 8, 2014
app: remove the restriction on app and platform names being the same
223dd94 
Related to #712.
fsouza pushed a commit that referenced this issue Dec 11, 2014
provision/docker: fix configuration name for docker registry in migra…
62ebcef 
…tion

Related to #712.
fsouza pushed a commit that referenced this issue Dec 11, 2014
provision/docker: push image after tagging when migrating it
1d962b9 
Related to #712.
fsouza pushed a commit that referenced this issue Dec 11, 2014
provision/docker: call migrateImages on Initialize
2c81695 
Related to #712 (only missing some tests, before I close it).
@fsouza fsouza closed this as completed in 2c61ab6 Dec 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fsouza fsouza

Labels
bug
Projects
None yet
Milestone
0.10.0
Development

No branches or pull requests
5 participants
@cezarsa @andrewsmedina @morpheu @fsouza @guestisp