Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Return non-zero exit code on validate when errors are found #59

Merged
merged 1 commit into from
Jan 22, 2019
Merged

WIP: Return non-zero exit code on validate when errors are found #59

merged 1 commit into from
Jan 22, 2019

Conversation

oleksandr-kuzmenko
Copy link
Member

Issue #57

Can we return 1 by default? Or only when process.env.CI exists? Or maybe we should add new flag for cli?

cc @MrOrz @AlexMost

@oleksandr-kuzmenko
Copy link
Member Author

I think we can return 1 by default in new ttag-cli release (1.6.0)

MrOrz
MrOrz approved these changes Jan 22, 2019
View reviewed changes
Copy link
Contributor

@MrOrz MrOrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a million

@AlexMost
Copy link
Member

AlexMost commented Jan 22, 2019 •
edited
Loading

Can we return 1 by default? Or only when process.env.CI exists? Or maybe we should add new flag for cli?

I think we should return 1 always if validation fails.

Thanks, @Alxpy! Is it still WIP or we are ready to merge this PR?

@AlexMost AlexMost merged commit 92bb4c9 into master Jan 22, 2019
@AlexMost AlexMost deleted the non-zero-exit-code branch January 22, 2019 08:58
@AlexMost
Copy link
Member

available in 1.6.0 🎉

@oleksandr-kuzmenko oleksandr-kuzmenko mentioned this pull request Jan 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrOrz MrOrz MrOrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleksandr-kuzmenko @AlexMost @MrOrz