Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Unmatch a user #240

Merged
merged 3 commits into from
Mar 4, 2022
Merged

Conversation

oliver-pham
Copy link
Collaborator

Related issue

Fixes #75

Type of Change

  • Feat: Change which adds functionality/new feature
  • Fix: Change which fixes an issue
  • Refactor: Change which improves the structure of the code
  • Docs: Change which improves documentation

Description

This PR should:

  • Add functionality for unmatching/blocking another user
  • Stop returning partners that either already unmatched the user or got unmatched by the user

Screenshot

Screen Shot 2022-02-26 at 11 49 16 PM
Screen Shot 2022-02-26 at 11 49 27 PM
Screen Shot 2022-02-26 at 11 49 34 PM

Testing

  1. Log in as Ashley White (ashley.white@seeksi.com)
  2. Use mutation unmatch to block Charlie Black, whose user ID is 6207f6f7f0323933be000009
  3. Check the matches and chatrooms collections

Note

The title of your PR should follow this format: [Type](area): Title

@vercel
Copy link

vercel bot commented Feb 27, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tuanthanh2067/seeksi/131jZn4zFhcVnewrWQNEasKSvThe
✅ Preview: https://seeksi-git-feature-75-send-unmatch-request-tuanthanh2067.vercel.app

Copy link
Owner

@tuanthanh2067 tuanthanh2067 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, approved!

But I have a question, this may affect creating potential matches as we definitely don't want to create another potential match for these 2. So I think we can check it when creating potential match.

@oliver-pham
Copy link
Collaborator Author

Good work, approved!

But I have a question, this may affect creating potential matches as we definitely don't want to create another potential match for these 2. So I think we can check it when creating potential match.

Noted! I'll add it to #237.

@oliver-pham oliver-pham merged commit 65f4c45 into main Mar 4, 2022
@oliver-pham oliver-pham deleted the feature/75-send-unmatch-request branch March 4, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User can unmatch another user
2 participants