Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: TubeArchivist isn't responsive on chrome based browser mobile screens (regression) #616

Closed
2 tasks done
adan89lion opened this issue Nov 25, 2023 · 4 comments
Closed
2 tasks done
Labels
bug Something isn't working pending-release Fixed and pending release

Comments

@adan89lion
Copy link

I've read the documentation

Operating System

Synology DSM 6.2 (64521)

Your Bug Report

Describe the bug

When accessing TubeArchivist from mobile devices, the website isn't responsive to small displays. This bug appears after 0.4.3 release, and still persists on 0.4.4 (latest) release. My test device is Samsung Galaxy S23 Ultra (on Android 14) and Google Chrome 119.0.6045.163.

Steps To Reproduce

  1. Upgrade to post TubeArchivist 0.4.3 release (where is bug happens).
  2. Browse the TubeArchivist instance from any mobile device.
  3. Notice the cropped-out webpage format, users are required to zoom-out to access some features.

Expected behavior

  1. The webpage should be responsive and adjusted for mobile experience.

Relevant log output

N/A

Anything else?

This is a screenshot of TubeArchivist installed as a PWA, indicating the cropped-out page.
Screenshot_20231125

@trafficman
Copy link

trafficman commented Nov 28, 2023

I can reproduce this cropping behavior in Chrome on desktop (it begins at the extreme edge of tablet mode), but Firefox behaves as expected (Firefox on top, Chrome on bottom, the mobile versions of both also behave identically):

image

For whatever reason, Chrome (I tested in Edge as well with the same results, it's likely all Chromium based browsers) seems to be behaving as if "width: 100%;" is absent from the top-banner style sheet, removing it in Firefox creates the same behavior:

image

A current temporary workaround could be to use Firefox mobile when accessing TA from a phone

@bbilly1
Copy link
Member

bbilly1 commented Dec 1, 2023

That must have been introduced in #583. @extome9000 can you look into this?

Or anybody using mobile chrome...

But yes, scaling on mobile firefox is working fine.

@bbilly1 bbilly1 added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Dec 1, 2023
@extome9000
Copy link
Contributor

extome9000 commented Dec 2, 2023

I did some testing and can confirm that it seems to be affecting Chromium browsers. I tested Brave, Chrome, Edge, and Vivaldi and they all have the same problem. trafficman's explanation is correct.
I used the content: var(--banner) attribute because it was very convenient for setting a specific banner per theme. I'll try and see if I can find a fix or workaround.

@bbilly1 bbilly1 changed the title [Bug]: TubeArchivist isn't responsive on mobile screens (regression) [Bug]: TubeArchivist isn't responsive on chrome based browser mobile screens (regression) Dec 2, 2023
bbilly1 added a commit that referenced this issue Dec 16, 2023
@bbilly1 bbilly1 added pending-release Fixed and pending release and removed help wanted Extra attention is needed good first issue Good for newcomers labels Dec 16, 2023
@bbilly1
Copy link
Member

bbilly1 commented Dec 21, 2023

Thanks for reporting, fixed merged in v0.4.5, please update.

@bbilly1 bbilly1 closed this as completed Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pending-release Fixed and pending release
Projects
None yet
Development

No branches or pull requests

4 participants