Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #623 channel audio mode #747

Conversation

greg321321
Copy link
Contributor

@greg321321 greg321321 commented Jun 13, 2024

Issue #623 .

@greg321321 greg321321 marked this pull request as draft June 13, 2024 09:47
@greg321321 greg321321 marked this pull request as ready for review June 15, 2024 02:41
@greg321321
Copy link
Contributor Author

ready for review

@bbilly1
Copy link
Member

bbilly1 commented Jul 6, 2024

Sorry, I should have looked closer at this earlier in the process.

Honestly, this is way too complicated. Also many of these things will change with the new frontend.

Sorry this is best to but on hold for now. For the sake of reference, things I'd do differently:

  • Auth like that in the url is very insecure, as that token, possibly with read/write access will be in plain text in the podcast app, in the logs, probably more places. We'd be better off to remove auth read only on the media files and the XML file, similar as with the cast integration. Or look into other ways how to lock down access...
  • The caching approach and transcoding the media files on request will likely not be feasible on lower end hardware, as you'll reach timeouts. So mp3 files should just go next to the mp4 files. Then you also don't need a separate mp3 route for that, as it's just part of media.

Ultimately, I appreciate the attempt, but we'll have to revisit that at a later point in time and look into implementing that in a way that is better integrated and more a audio mode that can also be used as podcast.

@bbilly1 bbilly1 closed this Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants