Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses a problem I encountered where my component defines defaultProps containing values of type other than string.
ex:
Storybook threw an error from
parseProps.js
because the value ofdefaultValueDesc.value
wasn't a string but was passed toclearString
which invokes.replace
on the arg.I’ve renamed this function to
getClearStringForVal
to better convey the expectation of receiving a “clear” string and to support the existing cases where this function receives values other than strings as arguments.