errors: fix regular expression #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Telegram Bot API now returns an extra field for error responses, such
as: {"ok":false,"error_code":429,"description":"Too Many Requests: retry
after 8","parameters":{"retry_after":8}}
|
We have similar #283, but no approved tests. Can you provide some so I will be able to merge your pull request? |
|
Sorry, my bad. I forgot to check the PR list, these two PRs are basically the same. 😅 Anyway, I added tests. And I think this is a problem that needs to be fixed ASAP, it caused too many panics. |
|
According to the contribution guide, you should change a base branch to |
Done. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Telegram Bot API now returns an extra field for error responses, such as:
{"ok":false,"error_code":429,"description":"Too Many Requests: retry after 8","parameters":{"retry_after":8}}This means that existing regular expression cannot extract errors normally, so it will cause panic.