feat(nvidia): Add cupti support #323
Conversation
There was a problem hiding this comment.
This file need comments. I have no idea what is happening here.
There was a problem hiding this comment.
Please document, what the functions bufferRequested, bufferCompleted, and callbackHandler do and when they will be called from cupti.
There was a problem hiding this comment.
After disccussing the ringbuffer a bit with @tilsche, we think it would be better to not let individual events split up on the wrap up, thus removing the need for all the mallocs, tracking thereof and simplifying the code at the same time. Also, fill shouldn't be necessary.
cvonelm
force-pushed
the
issue-294-cupti
branch
from
0dc5946
to
826026d
Compare
cvonelm
force-pushed
the
issue-294-cupti
branch
2 times, most recently
from
f5b30d8
to
3701440
Compare
cvonelm
force-pushed
the
issue-294-cupti
branch
2 times, most recently
from
08da629
to
1bddf27
Compare
cvonelm
force-pushed
the
issue-294-cupti
branch
2 times, most recently
from
732d27c
to
c950a74
Compare
There was a problem hiding this comment.
Please document, what the functions bufferRequested, bufferCompleted, and callbackHandler do and when they will be called from cupti.
cvonelm
force-pushed
the
issue-294-cupti
branch
3 times, most recently
from
7884ac2
to
4485359
Compare
This commit adds a --nvidia option, which injects a library into the program under measurement, which records entry and exit into CUDA kernels via CUPTI
cvonelm
force-pushed
the
issue-294-cupti
branch
from
4485359
to
b50f989
Compare
This commit adds a --nvidia option, which injects a library into the program under measurement, which records entry and exit into CUDA kernels via CUPTI
We might think about bumping the CMake requirement to 3.24 with this version, as older FindCUDAToolkit.cmake fail to correctly detect CUPTI headers[1].
This implements #294
[1] https://gitlab.kitware.com/cmake/cmake/-/merge_requests/7608