Fixed wrong parent in rollback search for containers after drag and drop #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikmaeckel
added a commit
that referenced
this pull request
Sep 22, 2021
* Fixed NullPointerException due to race condition in Frontend#sizeChanged. (#177) * Fix recursive position search in containers for MovementAnimation#toComponentView (#175) * Fixed recursive child position search for GridPanes. * Fixed FileDialogs returning list of nulls instead of empty optional. * Empty grid columns and rows no longer get rendered size 0.0 in case of fixed dimensions. (#180) * BoardGameScene getting shown blurred if showGameScene gets called after hideMenuScene. (#184) * Removed all non-null assertions replacing them with safe calls or state checks. (#185) * Fixed wrong parent in rollback search for containers after drag and drop. (#189) * Cleanup code fixing detect findings. * Fix toComponentView animation missing layoutFromCenter offset for Grid. (#190) * Fix toComponentView animation missing layoutFromCenter offset for Grid; toComponentView animation now working with scale. * Fix drag and drop for grid. * Fix drag and drop target for custom inter-cell-alignments
fabiankluempers
added a commit
that referenced
this pull request
Oct 29, 2021
* Fixed NullPointerException due to race condition in Frontend#sizeChanged. (#177) Closes #170 * Merged changes from #174. Closes #174. Closes #171. * Fix recursive position search in containers for MovementAnimation#toComponentView (#175) * Fixed recursive child position search for GridPanes. Closes #173 Closes #175 * Fixed FileDialogs returning list of nulls instead of empty optional. Updated CHANGELOG. Closes #181. * Empty grid columns and rows no longer get rendered size 0.0 in case of fixed dimensions. (#180) * Update CHANGELOG.md * Update CHANGELOG.md * BoardGameScene getting shown blurred if showGameScene gets called after hideMenuScene. (#184) Updated CHANGELOG. Closes #183. * Removed all non-null assertions replacing them with safe calls or state checks. (#185) * Fixed wrong parent in rollback search for containers after drag and drop. (#189) Closes #187 * Updated CHANGELOG. * Cleanup code fixing detect findings. * Fix toComponentView animation missing layoutFromCenter offset for Grid. (#190) * Update CHANGELOG.md * Fix toComponentView animation missing layoutFromCenter offset for Grid; toComponentView animation now working with scale. * Fix drag and drop for grid. Fix offset for grids nested in grid cells. * Fix drag and drop target for custom inter-cell-alignments * Remove println * Set version to 0.5-SNAPSHOT * Added scene wide key events * Added sudoku example. * Update CHANGELOG.md * Winning visualization in sudoku example. * Update README.md * Disable deselection of last RadioButton in ToggleGroup. Closes #195 * Change return type build functions in AnimationBuilder.kt from Animation to Transition * Add ParallelAnimation.kt and SequentialAnimation.kt * Add builder functions for parallel and sequential animations * Add KDoc to ParallelAnimation.kt and SequentialAnimation.kt * Add KDoc to builder functions for parallel and sequential Aniamtions * Fix KDoc style for parallel and sequential Animations * Moved examples to dedicated sub-module * Add secondary constructors for sequential and parallel animations. Improve KDoc for sequential and parallel animations. * added private constructor on utility class Trig * Fix license violations * Added tetris example. Add secondary constructors for sequential and parallel animations. Improve KDoc for sequential and parallel animations. * Update CHANGELOG.md Co-authored-by: Fabian Klümpers <fabian.kluempers@udo.edu>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #187