Feature/51 publish heartbeat #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced in 0c41ad75a169864cf24eb522c08136be99122019 of https://github.com/tue-robotics/diagnostics
LoyVanBeek
force-pushed
the
feature/51_publish_heartbeat
branch
from
1611c81
to
b801b02
Compare
reinzor
suggested changes
Apr 7, 2018
| updater = diagnostic_updater.Updater() | ||
| updater.setHardwareID("none") | ||
| updater.add(diagnostic_updater.Heartbeat()) | ||
| rospy.Timer(rospy.Duration(1), lambda event: updater.update()) |
There was a problem hiding this comment.
Please use the force_update method, the update method is already throttled on 1hz
|
|
||
| ros::Timer t = nh.createTimer(ros::Duration(1.0), | ||
| (const ros::TimerCallback &) [](const ros::TimerEvent& te)->void { | ||
| g_diagnostic_updater->update(); |
reinzor
previously approved these changes
Apr 11, 2018
reinzor
suggested changes
Jul 3, 2018
|
Also the Jenkins build is using indigo on trusty, I think this causes problems with the C++11 syntax |
LoyVanBeek
commented
Jul 7, 2018
|
Yes
…Sent from my iPhone
On 7 Jul 2018, at 10:42, Loy ***@***.***> wrote:
@LoyVanBeek commented on this pull request.
In openpose_ros/src/openpose_ros_node.cpp:
> @@ -162,6 +166,17 @@ int main(int argc, char** argv)
g_pub = nh.advertise<sensor_msgs::Image>("result_image", 1);
}
+ g_diagnostic_updater = std::shared_ptr<diagnostic_updater::Updater>(new diagnostic_updater::Updater());
+ g_diagnostic_updater->setHardwareID("none");
+
+ diagnostic_updater::Heartbeat heartbeat = diagnostic_updater::Heartbeat();
+ g_diagnostic_updater->add(heartbeat);
+
+ ros::Timer t = nh.createTimer(ros::Duration(1.0),
+ (const ros::TimerCallback &) [](const ros::TimerEvent& te)->void {
@reinzor this lambda is the only C++11 thing here, right?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Nice work, I think we should address the other nodes as well in this PR. Then we can merge next Tuesday :) |
|
@LoyVanBeek, are you planning to add these in the near future? |
|
Would be nice, but my time the coming weeks is severely limited and then I'm off on vacation for a couple of weeks, so fist time I can get around to it will be end of October. |
|
Tested |
reinzor
previously approved these changes
Nov 3, 2018
reinzor
approved these changes
Nov 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on using our fork of ROS diagnostics
Fixes #51