Fix typos in preface #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And please let me know if there are any places where you disagree with how I "fixed" something. I tried to keep my changes as close to your words as possible, but there were some places where I might have deviated from your intentions. |
tuhdo
reviewed
Feb 15, 2017
| @@ -502,7 +502,7 @@ There are many books on this topic and even courses out there already, made | |||
| book, and probably the students are assumed to obtain enough hardware knowledge | |||
| beforehand from other courses. | |||
| Or, the students only need to work within existing assignment framework: | |||
| the only thing they need to do is filling the empty function body, run | |||
| the only thing they need to do is fill the empty function body, run | |||
There was a problem hiding this comment.
I wish I could give you a more technical answer, but I'm honestly not sure of the exact reasons why "fill" is correct here. It's correct for the same reasons "run" and "complete" are correct in the same sentence though.
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for writing this book! I'm really enjoying it so far.
I'm fixing any typos and grammatical errors I catch as I work my way through the book. These are my fixes for the preface.
I kept each fix in a separate commit to make it easier to review, but I can squash them all together if you'd prefer to keep the commit history less noisy.