Add support for StoreKitConfigurationFileReference #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pepibumur I think this is ready to review! Changelog check is failing but I'm not sure if it's related :x |
pepicrft
reviewed
Oct 9, 2020
| @@ -0,0 +1,43 @@ | |||
| // | |||
There was a problem hiding this comment.
@jcolicchio would you mind removing the headers to be consistent with the rest of the codebase?
There was a problem hiding this comment.
Nevermind, I'll merge and fix those before releasing the next version.
|
@all-contributors add @jcolicchio for ideas |
|
@pepibumur I've put up a pull request to add @jcolicchio! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #574
Will allow XcodeGen to specify a StoreKit configuration file in the scheme
Short description 📝
Adds a new XML element,
StoreKitConfigurationFileReference, to theLaunchActionSolution 📦
Created
StoreKitConfigurationFileReferenceand added it toLaunchActionfollowing a similar pattern tolocationScenarioReferenceImplementation 👩💻👨💻
StoreKitConfigurationFileReferencemirroring structure ofLocationScenarioReferenceLaunchActionmirroring all usages and initializations oflocationScenarioReference