Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StoreKit Configuration file for scheme #2303

Closed
MarvinNazari opened this issue Jan 15, 2021 · 2 comments · Fixed by #2524
Closed

StoreKit Configuration file for scheme #2303

MarvinNazari opened this issue Jan 15, 2021 · 2 comments · Fixed by #2524
Assignees
Labels
type:enhancement New feature or request

Comments

@MarvinNazari
Copy link
Contributor

As of Xcode 12, It's possible to use a StoreKit configuration file for a scheme, as of today it's not possible to add this in the Tuist Project config. Is this even possible to add?

You can find it in Edit Scheme -> Options -> StoreKit Configuration.

@kwridan
Copy link
Collaborator

kwridan commented Jan 18, 2021

Hi @MarvinNazari - thanks for raising this.

Indeed at the moment there isn't an option to add this.

However that's something that can be added, from a cursory look the following is needed to support this:

  • Update the manifest scheme types in ProjectDescription.RunAction to include a new Options property to host the path to the store kit configuration (as well as other future additions from the Options tab)
struct RunAction {
    // ...
    var options: RunActionOptions?
}

struct RunActionOptions {
    var storeKitConfigurationPath: Path?
}

This will allow creating custom schemes that can reference this configuration

  • Update the corresponding models in TuistCore to copy across the options
  • Update the SchemeDescriptorGenerator to include storeKitConfigurationFileReference to the XCScheme.LaunchAction when the store kit option is set
  • For convenience, automatically include the referenced storeKitConfiguration file to the Project / Workspace where the scheme is defined as an additionalFile so it appears in Xcode's project navigator
  • For convenience, add a lint check to ensure the referenced StoreKit Configuration path exists

For reference, this is a PR @pepibumur contributed to add support for diagnostics options which entails a fairly similar set of changes #1382.

@bolismauro
Copy link
Contributor

Hi! I'll give this a shot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants