Scaffold load #1092
Scaffold load #1092
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1092 +/- ##
=========================================
- Coverage 75.14% 74.5% -0.64%
=========================================
Files 257 262 +5
Lines 11934 9164 -2770
=========================================
- Hits 8968 6828 -2140
+ Misses 2966 2336 -630
Continue to review full report at Codecov.
|
| @@ -75,7 +76,10 @@ public final class CommandRegistry { | |||
|
|
|||
| // Normal command | |||
| } else { | |||
| let parsedArguments = try parse() | |||
| guard let parsedArguments = try parse() else { | |||
| parser.printUsage(on: stdoutStream) | |||
There was a problem hiding this comment.
This is a good idea. We should do the same with other commands. Not as part of this PR though.
There was a problem hiding this comment.
This change is necessitated by this PR. parse() now returns optional ArgumentParser.Result if this does not include a command name. I can probably change this implementation back to its original signature.
| /// - parser: Default parser | ||
| /// - argumets: List of arguments that the user passed to the CLI | ||
| /// - Returns: Result of parsing the arguments that the user passed to the CLI. | ||
| func parse(with parser: ArgumentParser, arguments: [String]) throws -> ArgumentParser.Result |
There was a problem hiding this comment.
Does it need to be part of the protocol?
There was a problem hiding this comment.
Yes, otherwise I'd need to rewrite this
fixtures/ios_app_with_templates/Tuist/Templates/custom/Template.swift
Outdated
Show resolved
Hide resolved
Tests/TuistScaffoldIntegrationTests/Utils/TemplatesDirectoryLocatorIntegrationTests.swift
Outdated
Show resolved
Hide resolved
fixtures/ios_app_with_templates/Tuist/Templates/custom/Template.swift
Outdated
Show resolved
Hide resolved
|
I have addressed your comments, thanks for the review @pepibumur! Next up is generating, will start to work on that now π |
Short description π
Follow-up PR to models - note it will have to be merged first
This PR adds the functionality of defining custom templates in
Tuist/Templates+ loading the template and parsing it. Generation logic will be added in a follow-up PR.Solution π¦
Custom templates are defined in
Tuist/TemplatesinTemplate.swift. Model has already been defined in a previous PR. When runningtuist scaffold template --name hellowe need to find the template in custom templates directory and then dynamically add its parsed options (--name hellois not defined inScaffoldCommanditself)Implementation π©βπ»π¨βπ»
There are several things that needed to be added to make loading of templates work:
ProjectEditorto be able to edit the templates conveniently in Xcode projectTemplatesLoaderto be able to load the template manifestparsetoCommand-> this enables everyCommandto inject additional logic before runningparse. InScaffoldCommandwe leverage this to add options from template manifest and thus being able to runtuist scaffold template --name hellowhere--name hellois dynamically parsedTemplatesDirectoryLocatorthat leverages already implementedRootDirectoryLocator