Chimera - fetch carthage dependencies.

[laxmorek]

Short description 📝

Working on #1674

Adds possibility to install carthage dependencies defined in Tuist/Dependencies.swift using tuist dependencies fetch and tuist dependencies update commands.

Comments 🗒

• In .gitignore of app_with_framework_and_tests_and_dependencies I added Tuist/Dependencies/*. I don't want to track generated files.
• Frameworks are rebuilding with every run of tuist dependencies *. Im going to fix it in the next PR. I have done it
• I didn't add documentation and changelog changes. Feature isn't production ready.
• Let me know if documentation in the code is understandable. Please suggest me improvements if any need.

Implementation 👩‍💻👨‍💻

• Implement tuist dependencies fetch/update for carthage
• Add unit tests
• Add new fixture app_with_framework_and_tests_and_dependencies
• Add acceptance tests

[pepicrft]

Hey @laxmorek. Despite all my comments, I think the work is going in the right direction and the work is very aligned with how we do things in the project. Congratulations fur such a great contribution 👏

[laxmorek]

@pepibumur Thank you for your review. I adjusted PR to your suggestion. Could you revisit it?

[ferologics]

Reminder about the Carthage --use-netrc flag. It's essential when installing dependencies such as MapBox:

Install the SDK with carthage update --platform iOS --use-netrc
Always use the --use-netrc flag when running carthage bootstrap

[facumenzella]

Can we convert it to an enum? Since everything is static, we should avoid people going DependenciesDirectory()

[facumenzella]

I see that everything is a struct though 😅

[laxmorek]

I have followed convention in this file.

Constants.Vendor, Constants.DerivedDirectory etc

Im agree with you but I don't want to introduce a mess here.

[laxmorek]

Basically we should convert every struct in this file to enum. Should I do it in this PR? 🤔

[laxmorek]

Update 🙂

Dependencies.swift

From now dependency's requirements depends on dependency manager. There is also no longer common Dependency model. I created CarthageDependency and in the future we will provide CocoaPodDependency and SwiftPackageManagerDependency. API of Dependencies.swift has been changed.

Before:

import ProjectDescription

let dependencies = Dependencies([
    .carthage(name: "Alamofire/Alamofire", requirement: .exact("5.0.4"), platforms: [.macOS]),
    .carthage(name: "Swinject/Swinject", requirement: .exact("2.7.1"), platforms: [.macOS]),
])

Now:

import ProjectDescription

let dependencies = Dependencies(
    carthage: [
        .init(name: "Alamofire/Alamofire", requirement: .exact("5.0.4"), platforms: [.macOS]),
        .init(name: "Swinject/Swinject", requirement: .exact("2.7.1"), platforms: [.macOS]),
    ]
)

Tuist/Dependencies directory

New structure of Tuist/Dependencies directory:

Tuist
  |- Dependencies
    |- graph.json # not part of this PR 
    |- Lockfiles
      |- Carthage.resolved
      |- Podfile.lock # not part of this PR 
      |- Package.resolved # not part of this PR 
    |- Carthage
      |- Build
      |- Alamofire
        |- iOS
          |- Alamofire.framework
        |- tvOS
          |- Alamofire.framework
    |- Cocoapods # not part of this PR 
      |- RxSwift
    |- SwftPackageManager # not part of this PR 
      |- Moya

Frameworks handling

• I added a logic that removes frameworks from Tuist/Dependencies` if they are no longer needed.
• I added a logic that prevents rebuilding of frameworks.

Carthage command

• I added --use-netrc flag for carthage bootstrap and carthage update.

Others

• I updated changelog
• I didn't update documentation

[luispadron]

I haven't taken an in-depth look at the code since I lack the context here to make that useful but looking at the public API this feature is looking really nice!

Thanks for making the API more explicit and less possible to hit errors!

[pepicrft]

This should inherit from TuistUnitTestCase

[pepicrft]

This should inherit from TuistUnitTestCase

[pepicrft]

Since this is a unit test, it should inherit from TuistUnitTestCase.

[pepicrft]

Brilliant work @laxmorek. I think we are ready to merge here after addressing the final comments.