-
-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow import of multiple signing certs #2112
Conversation
Was using wrong syntax and therefore failed
first step is to fix import of public keys. |
Looked more into the issue of private keys: But then I found a much easier solution - it seems Keychain Access in fact handles duplicate imports of keys and either ignores them or replaces the old instance with a new one. One last thing was that I had one issue where the name extracted from the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks great, left just some minor comments 🎉
Tests/TuistSigningIntegrationTests/SecurityControllerIntegrationTests.swift
Outdated
Show resolved
Hide resolved
I'd wait for the main branch to be green (although it is not something you can fix in this PR), but otherwise no more comments, thanks! |
Was using wrong syntax and therefore failed
Resolves #2109
Short description 📝
Allow import of multiple certificates - before this PR only the first certificate was successfully imported. The command to check if a certificate was already supported used some unsupported/unknown arguments and therefore failed as soon as the keychain was not empty.
Solution 📦
Use correct syntax to check for the presence of a public key in the keychain. Was unable to find a mechanism to look up private keys (It seems to be possible only by name, but was unable to extract that name from the private key) but found out that when importing the same private key multiple times keychain handles that and only keeps one entry.