Fix an issue that caused the generation to fail when the resources glob includes a bundle #2183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b includes a bundle
pepicrft
requested review from
natanrolnik and
ollieatkinson
and removed request for
a team
|
@all-contributors add @jsorge for bug |
|
@pepibumur I've put up a pull request to add @jsorge! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #539
Short description 📝
As @asalom reported here andn @jsorge confirmed recently, when a resources glob includes a bundle, the generation of projects fails. That's because we try to add the files that are part of the bundle, to the resources build phase of the target. That's not right because we should add the bundle instead.
Solution 📦
Like we recently did with Playgrounds, I'm filtering out the files contained inside a
.bundlewhen mapping the `Target.