Add support for .s source files #2199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcvz
force-pushed
the
feature/accept-s-assembly-sources
branch
from
7a70487
to
16828e8
Compare
dcvz
force-pushed
the
feature/accept-s-assembly-sources
branch
from
16828e8
to
4f1909e
Compare
pepicrft
approved these changes
Dec 26, 2020
pepicrft
approved these changes
Dec 26, 2020
|
@all-contributors add @dcvz for code |
|
@pepibumur I've put up a pull request to add @dcvz! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/tuist/tuist/issues/YYY
Request for comments document (if applies):
Short description 📝
While migrating a large Swift/Objective-C++ codebase to use Tuist - I came across the need to use
.s(assembly) files as sources. This PR will add it to the whitelisted extensions.Checklist ✅
CHANGELOG.mdhas been updated to reflect the changes. In case of a breaking change, it's been flagged as such.