Fix false positive duplicate static products lint rule #2201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolved: tuist#2197 - The duplicate static products linter didn't take into account extensions, watch apps and app clips - Those can safely link the same static products linked by a host app as they are independent products - Updated the watch app fixture to include a local switch package to reproduce the previous false positive scenario Test Plan: - Run `swift build && swift run tuist generate --path fixtures/ios_app_with_watchapp2/` - Verify no duplicate static products lint warning is produced
pepicrft
approved these changes
Dec 27, 2020
fixtures/ios_app_with_watchapp2/Derived/Sources/Bundle+WatchAppExtension.swift
Outdated
Show resolved
Hide resolved
kwridan
force-pushed
the
fixes/false-positive-duplicate-static-products-in-extensions
branch
from
6c4ed9a
to
5102339
Compare
- explicitly specifying the `-sdk` can yield build errors when building a scheme that contains multiple products for different platforms (e.g. App with a bundled watch app)
|
I've had to update the acceptance test build commands (the ones in I did a sanity check on a few acceptance tests and that seemed to have worked, I guess we'll see how all of them fair on CI 😅 - if that fails, will revert the fixture change or add a different one not run by acceptance tests :/ |
|
looks like the change works for all fixtures on CI too 🎉 - the only CI failure is
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2197
Short description 📝
The duplicate static products linter was incorrectly flagging duplicate static products between host app targets and their additional bundled products (such as watch apps, app clips, extensions, etc...).
Those additional targets can safely link the same static products as their host app due them being independent products.
Checklist ✅
CHANGELOG.mdhas been updated to reflect the changes. In case of a breaking change, it's been flagged as such.In case the PR introduces changes that affect users, the documentation has been updated.Test Plan 🛠
swift build && swift run tuist generate --path fixtures/ios_app_with_watchapp2/