New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Package linter to validate path existence and url validity #2255
Conversation
Deploy request for tuist-next pending review. Review with commit 3b305a9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @adellibovi - thanks for submitting this!
Spotted a few minor things but this looks great overall.
Thanks @kwridan for the fast review! π |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@all-contributors add @adellibovi for code |
@pepibumur I've put up a pull request to add @adellibovi! π |
Thanks for tackling this @adellibovi βοΈ |
Resolves #2202
Short description π
Solves issue #2202, this PR add a new lint for Project which validates:
Checklist β
CHANGELOG.md
has been updated to reflect the changes. In case of a breaking change, it's been flagged as such.Am I missing something else?
P.S.: @pepibumur my first contribution is my way of saying enjoy your new flat, some people give furniture, some other PR I guess :)