Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Package linter to validate path existence and url validity #2255

Merged
merged 1 commit into from Jan 11, 2021
Merged

Add Package linter to validate path existence and url validity #2255

merged 1 commit into from Jan 11, 2021

Conversation

adellibovi
Copy link
Collaborator

@adellibovi adellibovi commented Jan 8, 2021

Resolves #2202

Short description πŸ“

Solves issue #2202, this PR add a new lint for Project which validates:

  • local path existence
  • url syntax validity

Checklist βœ…

  • The code architecture and patterns are consistent with the rest of the codebase.
  • A developer other than the author has verified that the changes work as expected.
  • The changes have been tested following the documented guidelines.
  • The CHANGELOG.md has been updated to reflect the changes. In case of a breaking change, it's been flagged as such.
  • In case the PR introduces changes that affect users, the documentation has been updated.

Am I missing something else?

P.S.: @pepibumur my first contribution is my way of saying enjoy your new flat, some people give furniture, some other PR I guess :)

@netlify
Copy link

netlify bot commented Jan 8, 2021

Deploy request for tuist-next pending review.

Review with commit 3b305a9

https://app.netlify.com/sites/tuist-next/deploys

Copy link
Collaborator

@kwridan kwridan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @adellibovi - thanks for submitting this!

Spotted a few minor things but this looks great overall.

Sources/TuistGenerator/Linter/PackageLinter.swift Outdated Show resolved Hide resolved
Sources/TuistGenerator/Linter/ProjectLinter.swift Outdated Show resolved Hide resolved
@adellibovi
Copy link
Collaborator Author

Thanks @kwridan for the fast review! πŸ˜„

Copy link
Collaborator

@kwridan kwridan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates!

Tested locally βœ…

Screenshot 2021-01-08 at 17 06 33
Screenshot 2021-01-08 at 16 59 51

One last bit, please update the change log to help highlight this new addition in the next release :)

@kwridan kwridan enabled auto-merge (squash) January 11, 2021 06:43
@pepicrft
Copy link
Contributor

@all-contributors add @adellibovi for code

@allcontributors
Copy link
Contributor

@pepibumur

I've put up a pull request to add @adellibovi! πŸŽ‰

@pepicrft
Copy link
Contributor

Thanks for tackling this @adellibovi ✌️

@pepicrft pepicrft merged commit 8578815 into tuist:main Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing local Swift Packages do not yield a generation error
3 participants