Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: read configuration from project if Target.settings is nil #2399

Merged
merged 5 commits into from Feb 2, 2021
Merged

Fix: read configuration from project if Target.settings is nil #2399

merged 5 commits into from Feb 2, 2021

Conversation

danieleformichelli
Copy link
Collaborator

Resolves #2370

Short description 📝

When Target.settings is nil, the settings should be read from the Project

Checklist ✅

  • The code architecture and patterns are consistent with the rest of the codebase.
  • A developer other than the author has verified that the changes work as expected.
  • The changes have been tested following the documented guidelines.
  • The CHANGELOG.md has been updated to reflect the changes. In case of a breaking change, it's been flagged as such.
  • In case the PR introduces changes that affect users, the documentation has been updated.

@fortmarek fortmarek self-requested a review January 30, 2021 07:32
pepicrft
pepicrft approved these changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@pepicrft pepicrft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this @danyf90 👏 . Would you mind reabasing to get CI green and updating the CHANGELOG.md?

@fortmarek fortmarek merged commit dedf5bb into tuist:main Feb 2, 2021
mollyIV added a commit to mollyIV/tuist that referenced this pull request Feb 3, 2021
@mollyIV
Merge branch 'main' into caching-profiles
62a949f 
* main:
  Project Plugins: Integrate plugins service. (tuist#2327)
  Fix CoreData project attributes (tuist#2397)
  [Chimera] Polishing docs (tuist#2424)
  Fix: read configuration from project if Target.settings is nil (tuist#2399)
  Send Analytics events to stats.tuist.io (tuist#2331)

# Conflicts:
#	CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepicrft pepicrft pepicrft approved these changes

@fortmarek fortmarek fortmarek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No project configuration is created by default
3 participants
@danieleformichelli @pepicrft @fortmarek