Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: fix autocompletion and improve documentation #2400

Merged
merged 5 commits into from Jan 31, 2021
Merged

Fix: fix autocompletion and improve documentation #2400

merged 5 commits into from Jan 31, 2021

Conversation

danieleformichelli
Copy link
Collaborator

@danieleformichelli danieleformichelli commented Jan 30, 2021 •
edited

Short description 📝

  • Fix the autocompletion to print the output to standard output instead of standard error
  • Improve the autocompletion documentation with details about how to generate the script

Checklist ✅

  • The code architecture and patterns are consistent with the rest of the codebase.
  • A developer other than the author has verified that the changes work as expected.
  • The changes have been tested following the documented guidelines.
  • The CHANGELOG.md has been updated to reflect the changes. In case of a breaking change, it's been flagged as such.
  • In case the PR introduces changes that affect users, the documentation has been updated.

fortmarek
fortmarek approved these changes Jan 30, 2021
View reviewed changes
Copy link
Member

@fortmarek fortmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for adding this missing piece 🖤

@fortmarek
Copy link
Member

This is good to merge once CI is green and please make sure to update changelog, too 🙏

@danieleformichelli danieleformichelli changed the title [Docs] Improve autocompletion documentation Fix: fix autocompletion and improve documentation Jan 30, 2021
@pepicrft pepicrft merged commit 48a29b8 into tuist:main Jan 31, 2021
mollyIV added a commit to mollyIV/tuist that referenced this pull request Feb 1, 2021
@mollyIV
Merge branch 'main' into cache-configuration-option
a0d889c 
* main:
  Treat CoreData files as resources for static/dynamic bundle generation (tuist#2376)
  [Chimera] Init documentation (tuist#2224)
  docs: add SergeyPetrachkov as a contributor (tuist#2417)
  Improve list-targets by sorting using topological order (tuist#2383)
  Revert topological sorting
  Fix missing vendor directory in built from source versions (tuist#2388)
  Fix: fix autocompletion and improve documentation (tuist#2400)

# Conflicts:
#	Sources/TuistKit/Cache/CacheController.swift
SergeyPetrachkov pushed a commit to SergeyPetrachkov/tuist that referenced this pull request Feb 1, 2021
@danieleformichelli @SergeyPetrachkov
Fix: fix autocompletion and improve documentation (tuist#2400)
3196edc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fortmarek fortmarek fortmarek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieleformichelli @fortmarek @pepicrft