Fix adding framework targets to AppClip #2530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepicrft
approved these changes
Feb 17, 2021
There was a problem hiding this comment.
Thanks for fixing this @sampettersson. Would you mind updating the CHANGELOG?
|
@all-contributors add @sampettersson for code |
|
@pepibumur I've put up a pull request to add @sampettersson! 🎉 |
|
@pepibumur I did add it here: https://github.com/tuist/tuist/pull/2530/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR14 did I do it wrong? 😅 |
fortmarek
approved these changes
Feb 17, 2021
| @@ -11,6 +11,7 @@ Please, check out guidelines: https://keepachangelog.com/en/1.0.0/ | |||
| ### Changed | |||
|
|
|||
| - Replace `ExpressibleByStringLiteral` with `ExpressibleByStringInterpolation` for `ProjectDescription` objects by [@DimaMishchenko](https://github.com/DimaMishchenko) | |||
| - Fix adding framework targets to AppClip by [@sampettersson](https://github.com/sampettersson) | |||
There was a problem hiding this comment.
add a link to the PR please (see below) => I think the log above does not have a PR link by mistake
sampettersson
force-pushed
the
fix-app-clip-frameworks
branch
from
9745fa9
to
e35028e
Compare
|
@all-contributors add @sampettersson for code |
|
@pepibumur I've put up a pull request to add @sampettersson! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description 📝
validLinkswasn't defined for.appClipending in an errorTarget A has a dependency with target B of type framework for platform 'iOS' which is invalid or not supported yet.this PR resolves that.Checklist ✅
CHANGELOG.mdhas been updated to reflect the changes. In case of a breaking change, it's been flagged as such.