Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use double quoted ruby imports #2634

Merged
merged 2 commits into from Mar 9, 2021
Merged

Use double quoted ruby imports #2634

merged 2 commits into from Mar 9, 2021

Conversation

fortmarek
Copy link
Member

@fortmarek fortmarek commented Mar 9, 2021

Short description πŸ“

It seems like main is failing because rubocop is warning about single-quoted strings for eg. require instead of double-quoted: https://github.com/tuist/tuist/runs/2063816194

Checklist βœ…

  • The code architecture and patterns are consistent with the rest of the codebase.
  • The changes have been tested following the documented guidelines.
  • The CHANGELOG.md has been updated to reflect the changes. In case of a breaking change, it's been flagged as such.
  • In case the PR introduces changes that affect users, the documentation has been updated.

Copy link
Collaborator

@laxmorek laxmorek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘

@fortmarek fortmarek merged commit bae7cc1 into main Mar 9, 2021
@fortmarek fortmarek deleted the ruby_imports branch March 9, 2021 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants