Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tuist test clean #2649

Merged
merged 1 commit into from Mar 12, 2021
Merged

Fix tuist test clean #2649

merged 1 commit into from Mar 12, 2021

Conversation

fortmarek
Copy link
Member

@fortmarek fortmarek commented Mar 11, 2021

Short description πŸ“

tuist test --clean was not working properly since in the last release I completely removed a BuildAction - which, when running xcodebuild clean test ... resulted in a failure because there were no targets set up for building.

With the changes, the build action is not removed completely but contains only test targets which test results have not been cached. Added also appropriate acceptance test to catch this in the future.

Checklist βœ…

  • The code architecture and patterns are consistent with the rest of the codebase.
  • The changes have been tested following the documented guidelines.
  • The CHANGELOG.md has been updated to reflect the changes. In case of a breaking change, it's been flagged as such.
  • In case the PR introduces changes that affect users, the documentation has been updated.

@fortmarek fortmarek force-pushed the test_clean branch 2 times, most recently from 077d0d7 to c617adf Compare March 11, 2021 21:22
@fortmarek fortmarek merged commit 58a843c into main Mar 12, 2021
@fortmarek fortmarek deleted the test_clean branch March 12, 2021 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants