Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support unversioned core data models #2694

Merged
merged 2 commits into from Mar 23, 2021

Conversation

freak4pc
Copy link
Sponsor Contributor

Short description πŸ“

Reported by @natanrolnik.
I fixed core data versioning in #2612, but forgot to handle the case a core data model has no version at all.

Checklist βœ…

  • The code architecture and patterns are consistent with the rest of the codebase.
  • The changes have been tested following the documented guidelines.
  • The CHANGELOG.md has been updated to reflect the changes. In case of a breaking change, it's been flagged as such.
  • In case the PR introduces changes that affect users, the documentation has been updated.

@freak4pc freak4pc added the type:bug Something isn't working label Mar 22, 2021
@freak4pc freak4pc self-assigned this Mar 22, 2021
Copy link
Collaborator

@kwridan kwridan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding support for this @freak4pc

Sources/TuistSupport/CoreDataVersionExtractor.swift Outdated Show resolved Hide resolved
Copy link
Contributor

@pepicrft pepicrft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides @kwridan's comment, I'd also update the CHANGELOG.

Copy link
Collaborator

@natanrolnik natanrolnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quickly adding this fix, @freak4pc !

@natanrolnik natanrolnik merged commit a41f39f into tuist:main Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants